Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mod cleanup: no_fungi mod #36189

Merged
merged 6 commits into from
Dec 19, 2019
Merged

Mod cleanup: no_fungi mod #36189

merged 6 commits into from
Dec 19, 2019

Conversation

arijust
Copy link
Contributor

@arijust arijust commented Dec 17, 2019

Summary

SUMMARY: None

Purpose of change

Helps with #36171

Describe the solution

Slowly fix bugs as test show them.
I was unable to check that locally, so I set up this as draft.

@ZhilkinSerg ZhilkinSerg added Code: Build Issues regarding different builds and build environments Mods Issues related to mods or modding Code: Tests Measurement, self-control, statistics, balancing. labels Dec 17, 2019
@arijust
Copy link
Contributor Author

arijust commented Dec 17, 2019

There are two errors which I don't have idea how to fix.

  1. "fruit" material seems to be invalid at comestibles.json
  2. overmap_feature_flag_settings seems to poorly support blacklists. Which could explain why certain third-party mods still have fungal overmap areas, unless that was caused by something else.

@arijust arijust changed the title Mod cleanup: no_fungi mod [WIP] Mod cleanup: no_fungi mod Dec 17, 2019
@arijust arijust marked this pull request as ready for review December 17, 2019 19:43
@ralreegorganon
Copy link
Contributor

overmap_feature_flag_settings seems to poorly support blacklists. Which could explain why certain third-party mods still have fungal overmap areas, unless that was caused by something else.

Got a link to an issue for mods having fungal overmap areas with this mod enabled (or a link to the mods in question)?

@arijust
Copy link
Contributor Author

arijust commented Dec 17, 2019

Mod in question is called Cataclysm++.
https://github.com/Noctifer-de-Mortem/nocts_cata_mod

@arijust
Copy link
Contributor Author

arijust commented Dec 17, 2019

These two errors I mentioned before, don't show up anymore.

I sometimes don't understand these code tests.

@arijust arijust changed the title [WIP] Mod cleanup: no_fungi mod Mod cleanup: no_fungi mod Dec 17, 2019
@ralreegorganon
Copy link
Contributor

@arijust The fungal special in that mod doesn't apply the FUNGAL flag to the location, therefore the blacklist can't exclude it. It needs to have the FUNGAL flag added to the flags here: https://github.com/Noctifer-de-Mortem/nocts_cata_mod/blob/c97418014ecdd2255cd4e2157934fb09ff038b32/Terrain/overmap_special.json#L141

@arijust
Copy link
Contributor Author

arijust commented Dec 18, 2019

The fungal special in that mod doesn't apply the FUNGAL flag to the location, therefore the blacklist can't exclude it.

That explains everything. I will need to tweak these myself at my next playthrough with that mod, I guess.

@I-am-Erk I-am-Erk merged commit 77eb9d5 into CleverRaven:master Dec 19, 2019
@arijust arijust deleted the no_fungi_check branch December 19, 2019 16:25
@weekly-digest weekly-digest bot mentioned this pull request Dec 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code: Build Issues regarding different builds and build environments Code: Tests Measurement, self-control, statistics, balancing. Mods Issues related to mods or modding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arijust @ralreegorganon @ZhilkinSerg @I-am-Erk